OliveTin: Shell And Exec Broken After 2025.11.06 Upgrade

by Alex Johnson 57 views

Are you experiencing issues with shell and exec actions after upgrading to OliveTin version 2025.11.06 or later? You're not alone. This article delves into a bug reported by users where upgrading to OliveTin version 2025.11.06 or later breaks shell and exec actions, specifically impacting actions that use popupOnStart and a confirmation argument. We'll explore the details of the bug, how to reproduce it, the expected behavior, and the environment in which it occurs. Let's dive in and understand this issue further.

The Bug: Shell and Exec Actions Failing After Upgrade

After upgrading to OliveTin version 2025.11.06 or later, users have reported that simple actions, such as ping commands, and other similar shell and exec actions, no longer function as expected. This issue was not present in version 2025.10.30. The core of the problem seems to stem from a combination of using popupOnStart and a confirmation argument in the action configuration. Users have noted that there was no explicit mention of breaking changes in the release notes, making this issue particularly unexpected.

Understanding the Impact

The breakage of shell and exec actions can significantly impact the functionality of OliveTin in various use cases. For instance, if you rely on OliveTin for executing system commands, running scripts, or performing other operational tasks, this bug can disrupt your workflows. It's crucial to understand the root cause and potential workarounds to mitigate the issue and ensure the smooth operation of your systems. Let's explore the specifics of how to reproduce this bug to gain a clearer understanding.

Reproducing the Bug: A Step-by-Step Guide

To reproduce this bug, follow these steps:

  1. Use OliveTin version 2025.11.11: Ensure you are running the affected version of OliveTin.

  2. Create an action with both popupOnStart and a confirmation argument:

    actions:
  - title: "ping google.com"
    shell: "ping -c 4 google.com"
    icon: 📡
    timeout: 300
    popupOnStart: execution-dialog-stdout-only
    acls: 
      - "public"
    arguments:
      - type: confirmation
        title: "Ping google.com? This will test connectivity."

  3. Navigate to OliveTin web interface: Open your web browser and access the OliveTin web interface.

  4. Click on the "ping google.com" action button: Locate the action button you created in the previous step and click it.

  5. Confirmation dialog appears: A dialog box should appear, prompting you to confirm the action with the message "Ping google.com? This will test connectivity."

  6. Click "Start" button on the confirmation dialog: Proceed by clicking the "Start" button.

  7. Open browser dev console (F12): Access the browser's developer console by pressing the F12 key.

  8. See error: Observe the error message in the console: ?action=ping+google.com:1 Form submission canceled because the form is not connected

  9. Action does not execute: You will notice that the ping command does not run, indicating the failure of the action.

By following these steps, you can consistently reproduce the bug and verify its presence in your environment. Now, let's contrast this with the expected behavior to highlight the discrepancy.

Expected Behavior: Smooth Execution and Output Display

In versions prior to 2025.11.06, the expected behavior after clicking "Start" on the confirmation dialog is that the action should execute the ping command seamlessly. The standard output (stdout) from the command should then be displayed in a popup dialog window, providing the user with real-time feedback on the execution. This smooth and intuitive workflow is crucial for many OliveTin users, and the disruption caused by the bug can be quite significant.

The Importance of Expected Behavior

The consistency of OliveTin's behavior is essential for maintaining user trust and ensuring a reliable experience. When users encounter unexpected issues, it can lead to frustration and potentially hinder their productivity. Understanding the expected behavior helps to highlight the deviation caused by the bug and underscores the need for a resolution. Let's now examine the screenshots provided to visualize the bug in action.

Visualizing the Bug: Screenshots and Error Messages

The provided screenshots offer a visual representation of the bug, making it easier to understand the issue. The first screenshot shows the confirmation dialog, which appears as expected. However, the subsequent screenshots reveal the problem.

Browser Dev Console Error

The key piece of information is the error message in the browser's developer console: ?action=ping+google.com:1 Form submission canceled because the form is not connected. This error suggests a fundamental issue with the form submission process, indicating that the form is being disconnected before it can be successfully submitted. This is a critical clue in diagnosing the root cause of the bug.

Interpreting the Error Message

The error message implies a potential JavaScript or DOM (Document Object Model) issue. It suggests that the form element, which is responsible for submitting the action, is being detached or disconnected from the DOM before the submission is complete. This could be due to a race condition, an incorrect event handler, or a problem with the way the dialog is being managed. Let's now delve into the environment details to understand the context in which this bug occurs.

Environment Details: Where the Bug Occurs

Understanding the environment in which the bug occurs is crucial for identifying potential causes and ensuring a targeted solution. Here are the key environmental factors:

  • OliveTin Version: 2025.11.11 (affected version)
  • Last working version: Versions earlier than 2025.10.30 work fine
  • First broken version: 2025.11.06 or later
  • Deployment: Docker container
  • Browser: Tested in multiple browsers (same issue)

Key Environmental Factors

The fact that the bug is reproducible across multiple browsers suggests that it is not a browser-specific issue. The deployment environment being a Docker container is also significant, as it rules out certain environment-specific factors. The most critical piece of information is the version range: the bug was introduced between versions 2025.10.30 and 2025.11.06. This narrows down the search for the root cause to the changes made during this period.

Additional Context: Regression and Impact

The additional context provided highlights the nature of the bug as a regression, meaning it is an issue that was introduced in a newer version after working correctly in a previous version. This is crucial information for developers as it suggests that a specific change in the codebase between 2025.10.30 and 2025.11.06 likely introduced the bug.

Impact on All Actions

It's also important to note that all actions in the configuration are affected, not just the ping example. This indicates that the bug is not specific to the ping command itself but rather a more general issue with the way actions are being handled, particularly those involving popupOnStart and confirmation arguments. This broad impact underscores the severity of the bug and the need for a comprehensive solution.

Form Submission Error: A Deeper Dive

The form submission error, as mentioned earlier, points to a DOM/JavaScript issue. The confirmation dialog form appears to be disconnected before submission completes. This could be due to various reasons, such as:

  • Incorrect event handling: An event handler might be inadvertently disconnecting the form.
  • Race condition: A race condition could be occurring, where the form is being submitted before it is fully connected to the DOM.
  • Asynchronous operations: Asynchronous operations might be interfering with the form submission process.

Conclusion: Addressing the OliveTin Bug

In conclusion, the bug where upgrading to OliveTin version 2025.11.06 or later breaks shell and exec actions is a significant issue that affects actions using popupOnStart and a confirmation argument. The error message Form submission canceled because the form is not connected points to a DOM/JavaScript issue. Understanding the steps to reproduce the bug, the expected behavior, and the environment in which it occurs is crucial for effective debugging and resolution.

If you are experiencing this issue, it is recommended to stay tuned for updates and potential workarounds from the OliveTin development team. You can also contribute to the discussion and share your experiences to help identify the root cause and facilitate a solution. Remember to always back up your configurations before upgrading to a new version to prevent any data loss or service disruption.

For further information and updates on OliveTin, you can visit the official OliveTin GitHub repository.